From 2ebb72e82ab2e99504096a22c69edfa068576696 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sun, 14 Dec 2008 00:43:09 +0000 Subject: [PATCH] Don't show an error dialog when changing to a non-existing folder, since * gtk/gtkfilechooserdefault.c (update_current_folder_get_info_cb): Don't show an error dialog when changing to a non-existing folder, since this is ususally just an annoyance. svn path=/trunk/; revision=21894 --- ChangeLog | 8 ++++++++ gtk/gtkfilechooserdefault.c | 9 +++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 81631deaaa..d0d26218ac 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-12-13 Matthias Clasen + + Bug 562579 – Remove error dialog when directory does not exist + + * gtk/gtkfilechooserdefault.c (update_current_folder_get_info_cb): + Don't show an error dialog when changing to a non-existing folder, + since this is ususally just an annoyance. + 2008-12-13 Matthias Clasen Bug 556233 – local-only causes G_IS_FILE warning diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c index 9dbb56b8be..1564730ae0 100644 --- a/gtk/gtkfilechooserdefault.c +++ b/gtk/gtkfilechooserdefault.c @@ -6926,8 +6926,13 @@ update_current_folder_get_info_cb (GCancellable *cancellable, } else { - /* error and bail out */ - error_changing_folder_dialog (impl, data->original_file, data->original_error); + /* Error and bail out, ignoring "not found" errors since they're useless: + * they only happen when a program defaults to a folder that has been (re)moved. + */ + if (!g_error_matches (data->original_error, G_IO_ERROR_NOT_FOUND)) + error_changing_folder_dialog (impl, data->original_file, data->original_error); + else + g_error_free (data->original_error); g_object_unref (data->original_file); goto out; -- 2.30.2